[PATCH] D28225: Implemented color coding and Vertex labels in XRay Graph
Alexis Shaw via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 24 15:29:02 PST 2017
varno marked an inline comment as done.
varno added inline comments.
================
Comment at: tools/llvm-xray/xray-graph.cc:580-586
+ auto ER2 = GR.accountRecord(Record);
+ if (ER2){
+ Err = joinErrors(std::move(ER2), std::move(Err));
+ if(!GraphKeepGoing)
+ return Err;
}
}
----------------
dberris wrote:
> This looks like it'd be better as:
>
> ```
> if (auto E = GR.accountRecord(Record)) {
> ...
> }
> ```
This does not quite work here.
https://reviews.llvm.org/D28225
More information about the llvm-commits
mailing list