[PATCH] D28583: CodeGen: Allow small copyable blocks to "break" the CFG.

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 15:08:09 PST 2017


On Tue, Jan 24, 2017 at 2:42 PM, Kyle Butt <iteratee at google.com> wrote:

>
>
> On Mon, Jan 23, 2017 at 8:44 PM, Xinliang David Li <davidxl at google.com>
> wrote:
>
>>
>>
>> I don't understand the reply. The early check I suggested is basically:
>>
>> if ( AdjustedSumProb - PProb > PProb)
>>    return false;
>>
>>
> The simple shortcut isn't correct. I made the loop look at the
> CFG-breaking tail-duplication candidates in a separate loop afterword.
>

can you clarify? What loop afterward?

David

>
> David
>>
>>>
>>>
>>> https://reviews.llvm.org/D28583
>>>
>>>
>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170124/9829b416/attachment.html>


More information about the llvm-commits mailing list