[PATCH] D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.cpp:295
+                                   InputSectionBase<ELFT> *Section) {
+  auto *S = new (BAlloc) DefinedRegular<ELFT>(
+      Name, /*IsLocal*/ true, STV_DEFAULT, Type, Value, Size, Section, nullptr);
----------------
Please use `make<DefinedRegular<ELFT>>(...)` instead of `new (BAlloc)`.


================
Comment at: ELF/SyntheticSections.cpp:1456
 
+template <class ELFT> void PltSection<ELFT>::addSymbols() {
+  Target->addPltHeaderSymbols(this);
----------------
Can you add a comment saying that ARM's .plt section usually contains local symbols? That is a foreign concept for those who are familiar only with x86.


https://reviews.llvm.org/D28956