[PATCH] D28848: [PM] Teach LoopUnroll to update the LPM infrastructure as it unrolls loops.

Michael Zolotukhin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 12:03:17 PST 2017


mzolotukhin accepted this revision.
mzolotukhin added a comment.
This revision is now accepted and ready to land.

LGTM with one question inline.

Michael



================
Comment at: lib/Transforms/Scalar/LoopPassManager.cpp:47-49
+    L.verifyLoop();
+    assert(L.isRecursivelyLCSSAForm(AR.DT, AR.LI) &&
+           "Loops must remain in LCSSA form!");
----------------
AFAIR, we have `lcssa-verification` pass now (see rL285394). Aren't we redoing it here?

I don't know if we want to keep that pass with the new pass manager, but still we probably want to have one or the other.


https://reviews.llvm.org/D28848





More information about the llvm-commits mailing list