[PATCH] D26967: Put opt-viewer critical items in parallel

Brian Cain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 11:39:34 PST 2017


bcain added a comment.

In https://reviews.llvm.org/D26967#653413, @anemet wrote:

> HI Brian!
>
> In https://reviews.llvm.org/D26967#653334, @bcain wrote:
>
> > If the .key property of Remark would be better off by having a self.Function element, should I just add it?
>
>
> I think we should just go with your patch as is and incrementally improve the situation from there.  As I said the original version is also incorrect so we're technically not regressing anything here.


Ok, thanks.  Can you commit this patch under review, then?  I don't believe that I have commit privileges.

-Brian


Repository:
  rL LLVM

https://reviews.llvm.org/D26967





More information about the llvm-commits mailing list