[PATCH] D29092: PR31729: [GVNHoist] Don't hoist unsafe scalars at -Oz

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya added inline comments.


================
Comment at: llvm/test/Transforms/GVNHoist/hoist-unsafe-pr31729.ll:3-6
+; CHECK-LABEL: @main
+; CHECK: urem
+; CHECK: urem
+; CHECK: urem
----------------
MatzeB wrote:
> How does this test work? If this is about hoisting wouldn't we always see 3 urem instructions no matter if we did the hoisting or not?
If urem is hoisted, then there will be only two urem. It can be verified by running this test without the patch.


https://reviews.llvm.org/D29092