[PATCH] D28985: [Builtin][ARM] Add Thumb1 support for aeabi_c{f,d}cmp.S and dcmp.S

Zhao, Weiming via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 11:00:52 PST 2017


Hi Renato,

MSR PSR, #imm is available in ARM ISA for  non-M profile.

M-profile is Thumb only, which at least supports MSR APSR, <Rn>

So the problem will happen only if we force ".thumb" for such asm files 
for some CPUs.


Thanks,

Weiming



On 1/24/2017 3:08 AM, Renato Golin via Phabricator wrote:
> rengolin added a comment.
>
> Hi Weiming,
>
> We have here the same problem as we had in the other patch: MRS/MSR is only available in ARMv6M. We'll have to find another way.
>
> cheers,
> --renato
>
>
>
> ================
> Comment at: lib/builtins/arm/aeabi_cdcmp.S:43
> +        lsls r0, #APSR_C_SHIFT
> +        msr APSR, r0
> +        pop {r0-r3, pc}
> ----------------
> MSR is not available in Thumb1.
>
>
> https://reviews.llvm.org/D28985
>
>
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation



More information about the llvm-commits mailing list