[PATCH] D29011: [IR] Add Freeze instruction

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: lib/AsmParser/LLParser.cpp:5914
+  if (!Op->getType()->isIntegerTy())
+    return Error(Loc, "cannot freeze non-integer type");
+
----------------
filcab wrote:
> filcab wrote:
> > Please test this error.
> Even better: Should this be in the verifier only? Otherwise you're checking for the same thing in two places, which is easy to get out of sync. (Would still require a test)
its not bad for them to be in both, the error messages are much nicer in the parser.


https://reviews.llvm.org/D29011