[PATCH] D28964: [PGO] Value profile support for value ranges

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

In fact, I don't there is a need for compiler_rt change at all for the interval/range profiling. The compiler_rt API should be kept simple.  In other words, interval profiling should already be 'lowered' into regular value profiling in the instrumentation lowering phase. The instrumentation lowering will general inline sequence that collapse ranges into single value depending on the value profile kind.  Only the __llvm_profile_instrument_target low level interface is needed.

The only downside of this approach that we can not override the range definitions at runtime -- but I don't think that is worth the complexity introduced.


Repository:
  rL LLVM

https://reviews.llvm.org/D28964