[PATCH] D29073: [ARM] Enable Cortex-M23 and Cortex-M33 support.

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

In https://reviews.llvm.org/D29073#654796, @sanwou01 wrote:

> > 4. Heavily modifying the SW/HWDIV test, even though the hardware description you added in TableGen has no mention of special DIV features that would separate it from the other M cores.
>
> The cortex-m23 is sufficiently different from the other processors checked in this file that the extra CHECK lines were necessary.  I can add a new file to test HWDIV on Thumb 1.  I'll submit a separate patch for that.


Right, extra checks are ok, changing the old check is risky. If there's too much bloat, you can split the test or just duplicate some of the `CHECK` lines.

The Thumb1 HWDIV test is probably best on its own.

cheers,
--renato


https://reviews.llvm.org/D29073