[PATCH] D29056: PowerPC: Mark super regs of reserved regs reserved.

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 24 05:02:33 PST 2017


nemanjai added inline comments.


================
Comment at: llvm/trunk/lib/Target/PowerPC/PPCRegisterInfo.cpp:254
+      if (!FuncInfo->usesTOCBasePtr() && !MF.hasInlineAsm()) {
+        for (MCSuperRegIterator Super(PPC::R2, this, true); Super.isValid();
+             ++Super)
----------------
I think it would be nice to have a function to do this just like there's a function to do the reverse. Maybe `unmarkSuperRegs()`? That way we can accomplish both setting the bits and resetting them for all the super registers with just a single call.

Is there a specific reason such a function was not added when `markSuperRegs()` was added?


Repository:
  rL LLVM

https://reviews.llvm.org/D29056





More information about the llvm-commits mailing list