[PATCH] D29061: [PM] Introduce a PoisoningVH as a (more expensive) alternative to AssertingVH that delays any reported error until the handle is *used*.

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy requested changes to this revision.
sanjoy added inline comments.
This revision now requires changes to proceed.


================
Comment at: include/llvm/IR/ValueHandle.h:383
+/// value
+/// is destroyed while the handle is still live.  This is very useful for
+/// catching dangling pointer bugs where an \c AssertingVH cannot be used
----------------
Reflow comment here.


================
Comment at: include/llvm/IR/ValueHandle.h:410
+
+#ifndef NDEBUG
+  /// A flag tracking whether this value has been poisoned.
----------------
I know you'll hate me for this, but this needs to be conditional on `LLVM_ENABLE_ABI_BREAKING_CHECKS` also.


https://reviews.llvm.org/D29061