[PATCH] D28435: [compiler-rt] Define delimiters for sanitizer coverage's binary section on Windows.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 16:26:44 PST 2017


mpividori added a comment.

@kcc Yes it belongs to asan, since that is the only place where we build the dlls for windows.
All the hooks for windows, interception, etc, are implemented inside asan directory, even though some of that code is related to sanitizer coverage. For example, you can see the file: `asan_win_dll_thunk.cc`, that we re using interception for all the functions of sanitizer coverage. And that code is in asan directory. I think this was coded that way to simplify the code, and avoid many files in different places.
I would like to reorganize all the files, but maybe in a different diff, in the future, after finishing with this?


Repository:
  rL LLVM

https://reviews.llvm.org/D28435





More information about the llvm-commits mailing list