[PATCH] D28435: [compiler-rt] Define delimiters for sanitizer coverage's binary section on Windows.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 15:31:40 PST 2017


mpividori added inline comments.


================
Comment at: lib/asan/asan_win_coverage_sections.cc:18
+__declspec(allocate(".SCOV$A")) uint32_t __start___sancov_guards = 0;
+__declspec(allocate(".SCOV$Z")) uint32_t __stop___sancov_guards = 0;
+}
----------------
rnk wrote:
> You can use the same technique as asan_globals_win.cc to avoid having a dynamic initializer in every TU with coverage.
@rnk Would you agree if we consider that in the future? I think this diff is OK for now, so we take the same approach than for linux and we simplify the code.
Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D28435





More information about the llvm-commits mailing list