[PATCH] D29051: Makes promoteIndirectCall an external function.
    David Li via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jan 23 15:18:02 PST 2017
    
    
  
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm with the nits.
================
Comment at: include/llvm/Transforms/Instrumentation.h:92
+// Helper function that transforms Inst (either a indirect-call instruction, or
+// an invoke instruction , to a conditional call to F. This is like:
+//     if (Inst.CalledValue == F)
----------------
a --> an 
extra space before ,
================
Comment at: include/llvm/Transforms/Instrumentation.h:100
+// Count is the profile count value that F is the target function.
+// These two values are being used to update the branch weight.
+// Returns the promoted direct call instruction.
----------------
are used
https://reviews.llvm.org/D29051
    
    
More information about the llvm-commits
mailing list