[PATCH] D28997: [LTO] Teach lib/LTO about the new pass manager

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

A couple of nits, otherwise LGTM



================
Comment at: lib/LTO/LTOBackend.cpp:46
+cl::opt<bool> LTOUseNewPM("lto-use-new-pm",
+                          cl::desc("Run passes using the new pass manager"),
+                          cl::init(false), cl::Hidden);
----------------
Maybe more explicit "Run LTO passes using..."


================
Comment at: test/ThinLTO/X86/error-newpm.ll:13
+
+define void @foo() {
+    ret void
----------------
Seems like this test could be even simpler since we are just checking for an error (i.e. a single function). Alternatively, if we want to instead make this a test that will eventually test the new PM when it is implemented for ThinLTO, maybe the file name should be changed to just "newpm.ll"?


https://reviews.llvm.org/D28997