[PATCH] D29029: Update domtree incrementally in loop peeling.
    Michael Kuperstein via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jan 23 11:18:52 PST 2017
    
    
  
mkuper accepted this revision.
mkuper added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of nits.
================
Comment at: lib/Transforms/Utils/LoopUnrollPeel.cpp:191
+
+    // If dominator tree is available, insert nodes to represent cloned blocks.
+    if (DT) {
----------------
Can you move this to immediately below line 207? I think it makes more sense to have this after the comment lines 203-206.
================
Comment at: lib/Transforms/Utils/LoopUnrollPeel.cpp:384
+#ifndef NDEBUG
+      if (VerifyDomInfo)
+        DT->verifyDomTree();
----------------
Can you decouple this from D29028?
I'd suggest just doing this under UnrollVerifyDomtree for now.
https://reviews.llvm.org/D29029
    
    
More information about the llvm-commits
mailing list