[PATCH] D29021: [ELF] - Stop handling local symbols in a special way.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D29021#653665, @ruiu wrote:

> Well, I think the problem was not in the code but in (the lack of) comments. It might have been OK if you add a comment saying that, for -r, we piggy back symbol's .symtab offsets to DynsymIndex because -r will never be used to produce DSOs. You probably want to spend more efforts on comments as it is sometimes the easiest way to solve a problem.


I'll try.

It might have work for -relocatable, but piggybacking does not work fine for --emit-relocs (https://reviews.llvm.org/D28612) as it is possible to use it in dynamic case.
I think --emit-relocs was initial reason of why this patch appeared :)


Repository:
  rL LLVM

https://reviews.llvm.org/D29021