[PATCH] D29003: [OptDiag] Move everything but code region into a new base class for DiagnosticInfoOptimizationBase

[Adam Nemet via Phabricator via llvm-commits]

anemet marked 4 inline comments as done.
anemet added a comment.

Thanks, Matthias!



================
Comment at: include/llvm/IR/DiagnosticInfo.h:381
+/// that are used by both IR and MIR passes.
+class DiagnosticInfoOptimizationCommonBase
+    : public DiagnosticInfoWithDebugLocBase {
----------------
MatzeB wrote:
> Why not call this `DiagnosticInfoOptimization` to make it a bit shorter and call the new thing `DiagnosticInfoIROptimization`/`DiagnosticInfoMIROptimization` (the fact that it is a `Base` class or `Common` is not that important that it needs to go into the name IMO).
Good suggestion.  Let me rename DiagnosticInfoOptimizationBase to DiagnosticInfoIROptimization in a prequel to this and rebase.


https://reviews.llvm.org/D29003