[llvm] r292648 - NewGVN: Fix PR 31686 and PR 31698 by rewriting store leader handling.

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 23 10:23:32 PST 2017


On Fri, Jan 20, 2017 at 1:33 PM, Davide Italiano <davide at freebsd.org> wrote:
> On Fri, Jan 20, 2017 at 1:04 PM, Daniel Berlin via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: dannyb
>> Date: Fri Jan 20 15:04:30 2017
>> New Revision: 292648
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=292648&view=rev
>> Log:
>> NewGVN: Fix PR 31686 and PR 31698 by rewriting store leader handling.
>>
>
> Can we backport this to 4.0 ?

There's a merge conflict. Maybe it's just formatting, but it makes it
more work to backport.

In general I'm starting to feel more skeptical about merging these
since NewGVN isn't on by default.

Trunk seems to be changing a bunch here, so there's work in keeping
up, and there's risk in taking the merges since even if the pass is
not enabled it does need to build and pass tests.

Why shuold we merge this one?

 - Hans


More information about the llvm-commits mailing list