[PATCH] D29024: [mips] Define macros related to -mabicalls in the preprocessor

[Simon Dardis via Phabricator via llvm-commits]

sdardis abandoned this revision.
sdardis added a comment.

I've reposted this to: https://reviews.llvm.org/D29032



================
Comment at: lib/Basic/Targets.cpp:7653
+      else
+        Builder.defineMacro("__mips_abicalls");
+    }
----------------
emaste wrote:
> If GCC always defines this one with abicalls (including on the BSDs) I think we should do the same.
It's an oddity, but FreeBSD's gcc/config/mips/mips.h doesn't define __mips_abicalls :

https://svn.freebsd.org/base/head/contrib/gcc/config/mips/mips.h

The definition of TARGET_CPU_CPP_BUILTINS doesn't include __mips_abicalls , even on 6.3.0 from the FreeBSD ports collection.

Contrast with : https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/mips/mips.h?view=markup#l595

and TARGET_CPU_CPP_BUILTINS does define __mips_abicalls.


Repository:
  rL LLVM

https://reviews.llvm.org/D29024