[PATCH] D29030: [LNT] Add cross-compilation support to 'lnt runtest test-suite'

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Hi Kristof,

Thanks for working on this, we really needed this functionality.

My question is if we shouldn't have only one way to pass options. I'm worried that the external file will confuse people.

For instance, if you specify the cross compiler by full path, it should be able to figure out the sysroot (bin/..) in most cases.

Also, that would work for GCC (with the triple in the name), but not for Clang. I see you're using "TARGET" for that, but other options (like -mthumb -mfloat-abi etc) will need to be passed as well.

I think these can be reduced cleanly to:

- CROSS_CC / CROSS_CXX
- CROSS_CFLAGS / CROSS_CXXFLAGS

and thus passed via LNT -- flags like all the others.

cheers,
--renato



================
Comment at: lnt/tests/test_suite.py:389
+
+        if self.opts.cc is not None and \
+           self.opts.cross_compiling_toolchain_file is not None:
----------------
So the tools like fpcmp will be compiled to the target and executed on the QEMU as well?


https://reviews.llvm.org/D29030