[PATCH] D28997: [LTO] Teach lib/LTO about the new pass manager

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/LTO/LTOBackend.cpp:248
+  if (Conf.OptUseNewPM || !Conf.OptPipeline.empty()) {
     // FIXME: Plumb the combined index into the new pass manager.
+    if (Conf.OptPipeline.empty())
----------------
davide wrote:
> mehdi_amini wrote:
> > In the meantime, we shouldn't accept the combination ThinLTO+Conf.OptUseNewPM.
> Indeed. Are you fine with this being a fatal error for the time being as the configuration is forbidden (similarly to what we do around line 212)?
> Otherwise I can just change the return value to std::pair<Error, bool> or return Error and pass bool as argument by reference, or whatever you like better.
I'm fine with a report_fatal_error for this.



Repository:
  rL LLVM

https://reviews.llvm.org/D28997