[PATCH] D28996: [PM] Flesh out the new pm LTO pipeline

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

LGTM. 
(Not sure about testing, may not be worth it at this point).



================
Comment at: lib/Passes/PassBuilder.cpp:553
+  MPM.addPass(GlobalDCEPass());
+
+  // Force any function attributes we want the rest of the pipeline to observe.
----------------
Alias analyses are added one layer above IIRC?


================
Comment at: lib/Passes/PassBuilder.cpp:575
+  // Small CGSCC pipeline to run PostOrderFunctionAttr pass.
+  CGSCCPassManager PostOrderCGPipeline(DebugLogging);
+
----------------
This seems dead?


================
Comment at: lib/Passes/PassBuilder.cpp:619
+  MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(InlinerPass()));
 
+  // Optimize globals again after we ran the inliner.
----------------
It seems that there is "PruneEH" in the legacy PM here?


Repository:
  rL LLVM

https://reviews.llvm.org/D28996