[PATCH] D28773: [ELF] - Avoid reusing DynsymIndex for -r

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 21 16:47:26 PST 2017


ruiu added a comment.

So I took a look at the code, and I think the current implementation of the -r option in regard to symbol indices is unnecessarily complicated. The logic is scattered over Writer.cpp and SyntheticSections.cpp, and we are handling -r in an obscure way there. It needs fixing from a broader perspective (e.g. moving the logic to SynethticSections) instead of a local fix.


https://reviews.llvm.org/D28773





More information about the llvm-commits mailing list