[PATCH] D28596: [compiler-rt] General definition for weak functions.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common.cc:508
 
-#if !SANITIZER_GO && !SANITIZER_SUPPORTS_WEAK_HOOKS
-SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE
-void __sanitizer_print_memory_profile(int top_percent) {
+#if !SANITIZER_GO
+WEAK_DEF(void, __sanitizer_print_memory_profile, int top_percent) {
----------------
mpividori wrote:
> aizatsky wrote:
> > I'm not sure what's up with !SANITIZER_GO here, do you know?
> @aizatsky I don't know, I think we can remove it.
> As far as I understand, `SANITIZER_GO` is a flag that we provide from the command line.
> For `SANITIZER_GO`  we ignore weak symbols in `sanitizer_internal_defs.h`.
@aizatsky  `SANITIZER_GO` flag is only used to build `ThreadSanitizer` runtime for Go. This condition was added in r285400: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20161024/400704.html  I think we can remove it, but to avoid problems, I don't.


https://reviews.llvm.org/D28596