majnemer added inline comments. ================ Comment at: lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:78-81 + struct TokOp { + const char *Data; + unsigned Length; + }; ---------------- Isn't this just a `StringRef`? https://reviews.llvm.org/D23563