[llvm] r292703 - [SLP] Make ReductionOpcode have the right (enum) type. NFC.
Michael Kuperstein via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 20 18:03:03 PST 2017
Author: mkuper
Date: Fri Jan 20 20:03:03 2017
New Revision: 292703
URL: http://llvm.org/viewvc/llvm-project?rev=292703&view=rev
Log:
[SLP] Make ReductionOpcode have the right (enum) type. NFC.
Modified:
llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp
Modified: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=292703&r1=292702&r2=292703&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (original)
+++ llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp Fri Jan 20 20:03:03 2017
@@ -4135,7 +4135,7 @@ class HorizontalReduction {
WeakVH ReductionPHI;
/// The opcode of the reduction.
- unsigned ReductionOpcode;
+ Instruction::BinaryOps ReductionOpcode;
/// The opcode of the values we perform a reduction on.
unsigned ReducedValueOpcode;
/// Should we model this reduction as a pairwise reduction tree or a tree that
@@ -4151,8 +4151,8 @@ public:
unsigned MinVecRegSize;
HorizontalReduction(unsigned MinVecRegSize)
- : ReductionRoot(nullptr), ReductionOpcode(0), ReducedValueOpcode(0),
- IsPairwiseReduction(false), ReduxWidth(0),
+ : ReductionRoot(nullptr), ReductionOpcode(Instruction::BinaryOpsEnd),
+ ReducedValueOpcode(0), IsPairwiseReduction(false), ReduxWidth(0),
MinVecRegSize(MinVecRegSize) {}
/// \brief Try to find a reduction tree.
@@ -4302,9 +4302,8 @@ public:
Value *ReducedSubTree = emitReduction(VectorizedRoot, Builder);
if (VectorizedTree) {
Builder.SetCurrentDebugLocation(Loc);
- VectorizedTree =
- Builder.CreateBinOp((Instruction::BinaryOps)ReductionOpcode,
- VectorizedTree, ReducedSubTree, "bin.rdx");
+ VectorizedTree = Builder.CreateBinOp(ReductionOpcode, VectorizedTree,
+ ReducedSubTree, "bin.rdx");
} else
VectorizedTree = ReducedSubTree;
}
@@ -4314,9 +4313,8 @@ public:
for (; i < NumReducedVals; ++i) {
Builder.SetCurrentDebugLocation(
cast<Instruction>(ReducedVals[i])->getDebugLoc());
- VectorizedTree =
- Builder.CreateBinOp((Instruction::BinaryOps)ReductionOpcode,
- VectorizedTree, ReducedVals[i]);
+ VectorizedTree = Builder.CreateBinOp(ReductionOpcode, VectorizedTree,
+ ReducedVals[i]);
}
// Update users.
if (ReductionPHI && !isa<UndefValue>(ReductionPHI)) {
@@ -4377,15 +4375,14 @@ private:
Value *RightShuf = Builder.CreateShuffleVector(
TmpVec, UndefValue::get(TmpVec->getType()), (RightMask),
"rdx.shuf.r");
- TmpVec = Builder.CreateBinOp((Instruction::BinaryOps)ReductionOpcode,
- LeftShuf, RightShuf, "bin.rdx");
+ TmpVec = Builder.CreateBinOp(ReductionOpcode, LeftShuf, RightShuf,
+ "bin.rdx");
} else {
Value *UpperHalf =
createRdxShuffleMask(ReduxWidth, i, false, false, Builder);
Value *Shuf = Builder.CreateShuffleVector(
TmpVec, UndefValue::get(TmpVec->getType()), UpperHalf, "rdx.shuf");
- TmpVec = Builder.CreateBinOp((Instruction::BinaryOps)ReductionOpcode,
- TmpVec, Shuf, "bin.rdx");
+ TmpVec = Builder.CreateBinOp(ReductionOpcode, TmpVec, Shuf, "bin.rdx");
}
}
More information about the llvm-commits
mailing list