[PATCH] D28546: LowerTypeTests: Implement importing of type identifiers.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:758
+    if (AbsWidth == PtrWidth)
+      SetAbsRange(~0ull, ~0ull);
+    else if (AbsWidth)
----------------
eugenis wrote:
> pcc wrote:
> > eugenis wrote:
> > > should this say 0ull, ~0ull ?
> > "~0ull, ~0ull" means the full set, whereas "0ull, ~0ull" means the full set except for the value ~0ull. From http://llvm.org/docs/LangRef.html#range-metadata : "The pair a,b represents the range [a,b).".
> > 
> > See also http://llvm-cs.pcc.me.uk/lib/IR/ConstantRange.cpp#237
> > 
> >  Added a comment.
> From http://llvm.org/docs/LangRef.html#range-metadata,
> 
>   The range should not represent the full or empty set. That is, a!=b.
> 
> Does the documentation need to be updated?
The doc for range is correct, but the one for absolute_symbol needs to be corrected. I'll do that.


https://reviews.llvm.org/D28546