[PATCH] D28331: Improve PGO support for the new inliner

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 20 11:31:52 PST 2017


davidxl added inline comments.


================
Comment at: test/Transforms/Inline/function-count-update-2.ll:12
+define i32 @caller1() !prof !2 {
+  %i = call i32 @callee()
+  ret i32 %i
----------------
eraman wrote:
> davidxl wrote:
> > Check no calls remaining.
> There is nothing interesting in terms of inlining here (ie the decision to inline here doesn't exercise any code path associated with this patch), but if you insist I'll add the checks.
This is just to make sure the inline decisions and expected end result of callee entry count are fully in sync.


https://reviews.llvm.org/D28331





More information about the llvm-commits mailing list