[PATCH] D28956: [LLD][ELF] Add support for local symbols in Synthetic Sections
    Rui Ueyama via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Jan 20 09:57:18 PST 2017
    
    
  
ruiu added a comment.
SymbolTable class in SymbolTable.cpp is a class to arbitrate global symbols, and currently it has no interaction with local symbols, because local symbols don't need any symbol name resolution. This patch is using that class as a storage to store synthetic symbols. I found that that's a bit confusing.
Can you move that to SyntheticSections.h or somewhere to make it clear that the symbol table doesn't do any business with local symbols?
https://reviews.llvm.org/D28956
    
    
More information about the llvm-commits
mailing list