[PATCH] D28331: Improve PGO support for the new inliner

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

Sorry for arriving late, glad to see this making progress! I left one comment inline.



================
Comment at: lib/Analysis/InlineCost.cpp:48-56
 static cl::opt<int> HintThreshold(
     "inlinehint-threshold", cl::Hidden, cl::init(325),
     cl::desc("Threshold for inlining functions with inline hint"));
 
+static cl::opt<int>
+    ColdCallSiteThreshold("inline-cold-callsite-threshold", cl::Hidden,
+                          cl::init(45),
----------------
Is it possible to introduce another `cl::opt` here to disable this mode while in PGO? It would be extremely useful for testing the benefit of this feature compared to what's already there in PGO.


https://reviews.llvm.org/D28331