[PATCH] D28875: AArch64LoadStoreOptimizer: Update kill flags when merging stores

[Matthias Braun via Phabricator via llvm-commits]

MatzeB marked an inline comment as done.
MatzeB added inline comments.


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:707
+      unsigned Reg = getLdStRegOp(*I).getReg();
+      for (MachineInstr &MI : make_range(NextI, Paired))
+        MI.clearRegisterKills(Reg, TRI);
----------------
mcrosier wrote:
> If the two instructions being paired happen to be adjacent to one another, NextI will point to the instruction after 'Paired'.  Is this going to behave as expected with make_range()?
Good point, for some reason that case never happened if MergeForward was true, but what I really should be used here is `std::next(I)`.


Repository:
  rL LLVM

https://reviews.llvm.org/D28875