[PATCH] D28919: Write the Named Stream Map and StringTable to yaml / binary

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/tools/llvm-pdbdump/LLVMOutputStyle.cpp:474-478
+      llvm::SmallString<32> Str;
+      Str.append("'");
+      Str.append(S);
+      Str.append("'");
+      P.printString(Str);
----------------
You might want to define `printString(const Twine &)` so that you don't need to use SmallString like this.


https://reviews.llvm.org/D28919