[PATCH] D28920: DAG: Allow targets to override stack temp alignment

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 14:29:24 PST 2017


arsenm created this revision.
Herald added subscribers: nhaehnle, wdng, qcolombet.
Herald added a reviewer: tstellarAMD.

AMDGPU doesn't want/need stack alignment > 4 ever. The
DataLayout's preferred alignment cannot be lower than the ABI
required alignment, which defaults to the type size. For
stack temporaries the ABI alignment constraints do not matter,
so request align 4 in all cases to save space.

      

This will mitigate regressing the stack usage of every program
 in a future commit.


https://reviews.llvm.org/D28920

Files:
  include/llvm/Target/TargetLowering.h
  lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/CodeGen/TargetLoweringBase.cpp
  lib/Target/AMDGPU/AMDGPUISelLowering.h
  test/CodeGen/AMDGPU/insert_vector_elt.ll
  test/CodeGen/AMDGPU/local-stack-slot-bug.ll
  test/CodeGen/AMDGPU/vgpr-spill-emergency-stack-slot-compute.ll
  test/CodeGen/AMDGPU/vgpr-spill-emergency-stack-slot.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28920.85035.patch
Type: text/x-patch
Size: 11059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170119/3581ea23/attachment.bin>


More information about the llvm-commits mailing list