[llvm] r292519 - [SCCP] Update comment in visitBinaryOp() after recent changes.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 13:07:42 PST 2017


Author: davide
Date: Thu Jan 19 15:07:42 2017
New Revision: 292519

URL: http://llvm.org/viewvc/llvm-project?rev=292519&view=rev
Log:
[SCCP] Update comment in visitBinaryOp() after recent changes.

Modified:
    llvm/trunk/lib/Transforms/Scalar/SCCP.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/SCCP.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/SCCP.cpp?rev=292519&r1=292518&r2=292519&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/SCCP.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/SCCP.cpp Thu Jan 19 15:07:42 2017
@@ -910,9 +910,10 @@ void SCCPSolver::visitBinaryOperator(Ins
 
   // Otherwise, one of our operands is overdefined.  Try to produce something
   // better than overdefined with some tricks.
-
-  // If this is an AND or OR with 0 or -1, it doesn't matter that the other
-  // operand is overdefined.
+  // If this is:
+  // -> AND/MUL with 0
+  // -> OR with -1
+  // it doesn't matter that the other operand is overdefined.
   if (I.getOpcode() == Instruction::And || I.getOpcode() == Instruction::Mul ||
       I.getOpcode() == Instruction::Or) {
     LatticeVal *NonOverdefVal = nullptr;




More information about the llvm-commits mailing list