[PATCH] D26967: Put opt-viewer critical items in parallel

[Brian Cain via Phabricator via llvm-commits]

bcain added a comment.

In https://reviews.llvm.org/D26967#617705, @anemet wrote:

> In https://reviews.llvm.org/D26967#616742, @bcain wrote:
>
> > Adam, can you provide a test case that illustrates the problem?  I didn't see it with the last two revisions.
>
>
> I just sent you an email with the details.


The differences are limited to the index.html.  Most of the differences are inconsequential.  I'm trying to explain them one by one and a few more unexplained ones remain, so stay tuned.

The inconsequential ones are due to ordering differences in the index.html between entries with identical hotness.  I can make those differences go away if I change both the baseline and the patch to have this line:

  sorted_remarks = sorted(all_remarks.itervalues(), key=lambda r: (r.Hotness, r.__dict__), reverse=True)

... instead of sorting on Hotness alone, this tuple also considers all the other fields of the remark.

I will include this change with my next update.  It would stabilize comparisons going forward but it won't make the output comparison from this patch match the baseline.


Repository:
  rL LLVM

https://reviews.llvm.org/D26967