[PATCH] D28861: [Assembler] Improve error when unable to evaluate expression.

Sanne Wouda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 19 04:15:07 PST 2017


sanwou01 updated this revision to Diff 84955.
sanwou01 edited the summary of this revision.
sanwou01 added a comment.

Removed uses of CHECK-DAG where they were unnecessary. Still required for the last two tests in ARM/error-location-post-layout.s because these /do/ come out in the "wrong" order.

@grosbach, I will be working on improving diagnostics throughout the assembler. So yes, I will be threading this through to the AsmParser whenever I come across an MCExpr with a default SMLoc.  Seems reasonable to do this incrementally.


https://reviews.llvm.org/D28861

Files:
  include/llvm/MC/MCExpr.h
  lib/MC/MCExpr.cpp
  lib/MC/MCFragment.cpp
  lib/MC/MCParser/AsmParser.cpp
  test/MC/AArch64/error-location-post-layout.s
  test/MC/ARM/error-location-post-layout.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D28861.84955.patch
Type: text/x-patch
Size: 9461 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170119/90754f68/attachment.bin>


More information about the llvm-commits mailing list