[PATCH] D28068: Whenever reasonable, merge ASAN quarantine batches to save memory.
Evgeniy Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 18 18:05:56 PST 2017
eugenis added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_quarantine.h:38
+ batch[0] = ptr;
+ this->size = size + sizeof(QuarantineBatch); // Account for the batch size.
+ }
----------------
would it make the code simpler if we removed sizeof(QuarantineBatch) from here?
================
Comment at: lib/sanitizer_common/sanitizer_quarantine.h:125
// It assumes that the world is stopped, just as the allocator's PrintStats.
+ Printf("Quarantine options: global: %zdMb; thread local: %zdKb\n",
+ GetSize() >> 20, GetCacheSize() >> 10);
----------------
s/options/limits
https://reviews.llvm.org/D28068
More information about the llvm-commits
mailing list