[PATCH] D27962: Get function start line number from DWARF info

[Eric Christopher via llvm-commits]

As a followup to some offline conversation:

Simon is going to add an "address verbose mode" to llvm-symbolizer that
provides some decent debugging capabilities and will show a more useful
need for this information.

As an outside user as well - the autofdo profiling generation project also
uses this code and is contained in a github project.

Thanks!

On Tue, Jan 17, 2017 at 5:51 PM Simon Que via Phabricator <
reviews at reviews.llvm.org> wrote:

> sque added a comment.
>
> In https://reviews.llvm.org/D27962#649079, @echristo wrote:
>
> > > 0x406f1f
> > >  bool error<llvm::DILineInfo>(llvm::Expected<llvm::DILineInfo>&)
> > >
> /usr/local/google/home/sque/code/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:89:0
> > >  Start line: 89
> >
> > Hrm. But it already had the line above?
>
>
> Bad example, that was the first line of the function. How about:
>
> sque at sq:~/code/llvm-build $  bin/llvm-symbolizer -obj=bin/llvm-symbolizer
> 0x406f2d
> bool error<llvm::DILineInfo>(llvm::Expected<llvm::DILineInfo>&)
>
> /usr/local/google/home/sque/code/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:90:0
> Start line: 89
>
> 0x406f30
> bool error<llvm::DILineInfo>(llvm::Expected<llvm::DILineInfo>&)
>
> /usr/local/google/home/sque/code/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:90:0
> Start line: 89
>
> 0x406f40
> bool error<llvm::DILineInfo>(llvm::Expected<llvm::DILineInfo>&)
>
> /usr/local/google/home/sque/code/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:91:0
> Start line: 89
>
> 0x406f50
> bool error<llvm::DILineInfo>(llvm::Expected<llvm::DILineInfo>&)
>
> /usr/local/google/home/sque/code/llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:93:0
> Start line: 89
>
>
> https://reviews.llvm.org/D27962
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170119/f66a93c2/attachment.html>