[PATCH] D28170: [LICM] When promoting scalars, allow inserting stores to thread-local allocas

[Michael Kuperstein via llvm-commits]

Haven't given it much thought - I copied this from the existing tests, and
modified only the parts I needed.

On Tue, Jan 17, 2017 at 9:39 PM, Xin Tong via Phabricator <
reviews at reviews.llvm.org> wrote:

> trentxintong added inline comments.
>
>
> ================
> Comment at: llvm/trunk/test/Transforms/LICM/promote-tls.ll:67
> +  %old = load i32, i32* %addr, align 4
> +  ; deliberate impossible to analyze branch
> +  %guard = load atomic i8*, i8** @p monotonic, align 8
> ----------------
> Any particular reason why this can not be br i1 undef, label %a, label %b
> ? Understandably, this can be simplified by SimplifyCFG or SCCP. but we are
> only running LICM here ?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D28170
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170118/0611a7c4/attachment.html>