[PATCH] D28737: [ThinLTO] Don't create a comdat group for a dropped def with initializer

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 18 08:43:05 PST 2017


tejohnson added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1653
         // will provide its dynamic initializer.
         continue;
 
----------------
mehdi_amini wrote:
> Do we need a ThinLTO importing to expose this case?
> Can't you have a "simple" llc test that test the CodeGen for this?
Good idea, done.


https://reviews.llvm.org/D28737





More information about the llvm-commits mailing list