[PATCH] D28854: raw_fd_ostream: Make file handles non-inheritable by default

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added inline comments.


================
Comment at: lib/Support/Unix/Path.inc:648
+    (void)r;
+    assert(r == 0);
+  }
----------------
In general, please add `&& "something useful"` so that people who trigger this assert have a chance to know what went wrong.


================
Comment at: lib/Support/Windows/Path.inc:778
+  SECURITY_ATTRIBUTES sa;
+  sa.nLength = sizeof sa;
+  sa.lpSecurityDescriptor = nullptr;
----------------
Please add parens around the argument.


https://reviews.llvm.org/D28854