[PATCH] D28840: IPO, LTO: Plumb the summary from the LTO API into the pass manager.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/include/llvm/LTO/LTOBackend.h:38
 /// Runs a regular LTO backend.
 Error backend(Config &C, AddStreamFn AddStream,
               unsigned ParallelCodeGenParallelismLevel,
----------------
May not be straightforward to know why "a regular LTO backend" need a "CombinedIndex", so worth commenting.


================
Comment at: llvm/include/llvm/Transforms/IPO/PassManagerBuilder.h:128
+  /// The module summary index to use for passing information between the
+  /// regular LTO phase and the thin LTO backends.
+  ModuleSummaryIndex *Summary = nullptr;
----------------
I'd add `, for example the CFI and devirtualization type tests.`


================
Comment at: llvm/lib/LTO/LTOBackend.cpp:199
   else
     runNewPMCustomPasses(Mod, TM, Conf.OptPipeline, Conf.AAPipeline,
                          Conf.DisableVerify);
----------------
FIXME?


https://reviews.llvm.org/D28840