[PATCH] D28424: LowerTypeTests: Implement exporting of type identifiers.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

The test are a bit obscure for someone who does not know well how the type-tests works.

If @eugenis can review this, that'd be great, otherwise I'll try to "page this in" later this week and get it done.



================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:257
+  // Mapping from type identifiers to the call sites that test them, as well as
+  // whether the type identifier needs to be exported.
+  struct TypeIdUserInfo {
----------------
May not be straightforward to know what it means to "be exported" when reading this code.


================
Comment at: llvm/lib/Transforms/IPO/LowerTypeTests.cpp:697
 
+void LowerTypeTestsModule::exportTypeId(StringRef TypeId,
+                                        const TypeIdLowering &TIL) {
----------------
One line comment before this function?


https://reviews.llvm.org/D28424