[PATCH] D28822: Add a test case for LICM when promoting locals that may be read after the throw within the loop. NFCI.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 17 13:30:51 PST 2017
efriedma added a comment.
LGTM.
================
Comment at: test/Transforms/LICM/scalar-promote-unwind.ll:75
+; This is a test which the loop is within a try block, we must make sure that there is the explicit
+; unwind edge out of the loop due to the fact that boo() may throw and its treated as a loop exit.
+; And that loads/stores are promoted as expected.
----------------
Run-on sentence, and a little hard to understand in general. Maybe "In this test, a loop is within a try block. There is an explicit unwind edge out of the loop. Make sure this edge is treated as a loop exit, and that the loads and stores are promoted as expected."
https://reviews.llvm.org/D28822
More information about the llvm-commits
mailing list