[PATCH] D28596: [compiler-rt] General definition for weak functions.

[Marcos Pividori via Phabricator via llvm-commits]

mpividori added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_internal_defs.h:74
 # define SANITIZER_INTERFACE_ATTRIBUTE __attribute__((visibility("default")))
 # define SANITIZER_WEAK_ATTRIBUTE  __attribute__((weak))
+# define WEAK(ReturnType, Name, Params)                                        \
----------------
rnk wrote:
> We should consider removing this macro eventually and migrate all users over to the new API.
Exactly, but I was waiting for review on the new macro before migrating everything.


Repository:
  rL LLVM

https://reviews.llvm.org/D28596