[PATCH] D28574: [scudo] Refactor of CRC32 and ARM runtime CRC32 detection

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 09:08:09 PST 2017


phosek added inline comments.


================
Comment at: lib/scudo/scudo_utils.cpp:110
+bool testCPUFeature(CPUFeature Feature) {
+  static uptr HWCap = getauxval(AT_HWCAP);
+
----------------
cryptoad wrote:
> phosek wrote:
> > This is likely going to create a dependency on libc++ similarly to D28757.
> Changing that. Is calling getauxval OK?
Yes that's fine, it's the static initialization that's the problem.


https://reviews.llvm.org/D28574





More information about the llvm-commits mailing list