[PATCH] D28744: [X86][AVX] Remove "OptForSize" condition from some memory foldings.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 04:03:31 PST 2017


RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:1928
+    { X86::VRCP14SSrr,        X86::VRCP14SSrm,          TB_NO_REVERSE },
+    { X86::VRSQRT14SSrr,      X86::VRSQRT14SSrm,        TB_NO_REVERSE },
     { X86::VSHUFPDZrri,       X86::VSHUFPDZrmi,         0 },
----------------
Isn't it only the _Int variants that need TB_NO_REVERSE ?


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:1932
+    { X86::VSQRTSSZr,         X86::VSQRTSSZm,           0 },
+    { X86::VSQRTSDZr,         X86::VSQRTSDZm,           0 },
     { X86::VSUBPDZrr,         X86::VSUBPDZrm,           0 },
----------------
All these changes to X86InstrInfo.cpp should probably be split off - add them to the stack-folding-*.ll tests


https://reviews.llvm.org/D28744





More information about the llvm-commits mailing list