[PATCH] D28549: Global DCE performance improvement

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: include/llvm/Transforms/IPO/GlobalDCE.h:22
+#include "llvm/ADT/DenseMap.h"
+#include "llvm/ADT/SmallSet.h"
 #include "llvm/IR/Module.h"
----------------
Are you still using `SmallSet` or is this a dead include?


================
Comment at: lib/Transforms/IPO/GlobalDCE.cpp:132
 PreservedAnalyses GlobalDCEPass::run(Module &M, ModuleAnalysisManager &) {
+
   bool Changed = false;
----------------
stray newline?


================
Comment at: lib/Transforms/IPO/GlobalDCE.cpp:187
+  while (!NewLiveGVs.empty()) {
+    auto *LGV = NewLiveGVs.pop_back_val();
+    for (auto *GV : GVDependencies[LGV])
----------------
Please use an explicit type here


================
Comment at: lib/Transforms/IPO/GlobalDCE.cpp:188
+    auto *LGV = NewLiveGVs.pop_back_val();
+    for (auto *GV : GVDependencies[LGV])
+      MarkLive(*GV, &NewLiveGVs);
----------------
and here, and I guess everywhere else the type is not really obvious (for consistency with what's already in the pass).


================
Comment at: lib/Transforms/IPO/GlobalDCE.cpp:189
 
-  // Make sure that all memory is released
   AliveGlobals.clear();
----------------
Why did you remove this comment?


Repository:
  rL LLVM

https://reviews.llvm.org/D28549